Support timestamp seconds precisions with more than 3 fractional digits
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 322
- Forks
- 99
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
we want to use timestamps with seconds precisions of more than 3 fractional digits, such as 2022-11-05T12:35:44.1234567Z. SAP HANA supports up to 7 digits which are correctly written and read by @sap/hana-client. However, unfortunately it seems as though in node-hdb the fractional digits are always rounded to 3 decimal places here and probably also here.
Could you please add support for seconds precisions of more than 3 fractional digits?
Thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the timestamp handling in lib/protocol/Writer.js around line 556 and lib/protocol/Reader.js around lines 140-147. Reproduce the issue with a timestamp such as 2022-11-05T12:35:44.1234567Z; done means node-hdb preserves fractional seconds beyond three digits when writing and reading.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- backend, databases
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100