SAP / SAP/node-hdb

Decimal number like .8 cannot be accepted

Open
#208 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
322
Forks
99
PR merge metrics
No merged PRs in 30d

Description

When trying to insert to a column table, with decimal number '.8' ( for example) to a column of DECIMAL data type, an error 'Wrong input for DECIMAL type' would be raised.

Kindly fix the issue, thanks!

p.s. 1. data like '0.8' is OK;
2. Is it OK if I submit a fix for this problem and will the submit be accepted?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the node-hdb source and tests for the exact error message “Wrong input for DECIMAL type” and trace how decimal values are validated. Confirm that values such as '.8' are accepted like '0.8', then add or update coverage for both forms and run the relevant test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js, sql
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.