Connection.js crash issue
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 322
- Forks
- 99
- PR merge metrics
- No merged PRs in 30d
Description
We are using older version of hdb - 0.13.0.
We saw a very rare issue resulted in node instance restart.
/app/node_modules/hdb/lib/protocol/Connection.js:280
4/6/20 1:14:28.619 AM [APP/2-0] ERR state.messageType = message.type;
4/6/20 1:14:28.619 AM [APP/2-0] ERR ^
4/6/20 1:14:28.619 AM [APP/2-0] ERR
4/6/20 1:14:28.619 AM [APP/2-0] ERR TypeError: Cannot set property 'messageType' of undefined
4/6/20 1:14:28.619 AM [APP/2-0] ERR at Connection.send (/app/node_modules/hdb/lib/protocol/Connection.js:280:21)
4/6/20 1:14:28.619 AM [APP/2-0] ERR at send (//app/node_modules/hdb/lib/protocol/ExecuteTask.js:189:21)
4/6/20 1:14:28.619 AM [APP/2-0] ERR at next (/app/node_modules/hdb/lib/protocol/ExecuteTask.js:157:14)
4/6/20 1:14:28.619 AM [APP/2-0] ERR at handleParameters (/app/node_modules/hdb/lib/protocol/ExecuteTask.js:152:5)
4/6/20 1:14:28.619 AM [APP/2-0] ERR at Immediate. (//app/node_modules/hdb/lib/protocol/Writer.js:199:7)
4/6/20 1:14:28.619 AM [APP/2-0] ERR at runCallback (timers.js:672:20)
4/6/20 1:14:28.619 AM [APP/2-0] ERR at tryOnImmediate (timers.js:645:5)
4/6/20 1:14:28.619 AM [APP/2-0] ERR at processImmediate [as _immediateCallback] (timers.js:617:5)
I don't know how to reproduce this but this happened only once.
I saw a similar issue https://github.com/SAP/node-hdb/issues/105.
Just wanted to make sure if they are related and possible upgrade should fix this.
Any pointers will really help.
Thanks,
Ramana.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading lib/protocol/Connection.js around line 280, then trace the calls from ExecuteTask.js and Writer.js shown in the stack trace. Compare the behavior in hdb 0.13.0 with the related issue #105 and newer versions. Done would mean establishing whether the reports share a cause and documenting or testing a reliable fix, but reproduction is currently missing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100