SAP / SAP/code-pal-for-abap

False positives for check Message Easy To Find

Open
#588 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
ABAP
Stars
435
Forks
77
PR merge metrics
No merged PRs in 30d

Description

Check Name
Message Easy To Find

Issue
The check produces a high number of false positives. Here are some examples where this can be observed:

  1. The check does also report findings for messages in text pools which makes no sense. Example code:

    data lv_etext type c length 100.
    lv_etext = 'No authority to replay'(e12).
    message lv_etext type 'I'.

  2. The check reports findings for messages that are thrown without the use of a message class (at least when you add a RAISING to the statement). Example code:

    data l_text type string.
    l_text = 'success'.
    message l_text type 'I' raising a.

  3. Even when the message class and message number are correctly defined with literals, the check raises a finding as soon as the addition 'WITH' or 'RAISING' or both of them are used. Example Code:

    message id '/AIF/BDC' type 'E' number '013' with iv_typename raising a.

I also found many cases where the statement was completely fine and the check still reported a finding, but I wasn't able to see a pattern when this happens and when not.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the “Message Easy To Find” check and reproduce the three ABAP examples in the issue, including text-pool messages and MESSAGE statements using WITH or RAISING. Done means valid statements no longer produce findings while genuine violations remain detectable; the issue does not name a file or test to run.

Written by the indexing model from the issue text.

Assessment

Domain
devtools, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.