SAP / SAP/code-pal-for-abap

Customization of evaluation of new child objects

Open
#331 7 comments 0 reactions 1 assignee View on GitHub

@lucasborin is already working on this.

Since Dec 10, 2021.

  • #539 by @lucasborin — closed without merging
feature
Dominant language
ABAP
Stars
435
Forks
77
PR merge metrics
No merged PRs in 30d

Description

Is it possible to exclude new objects created in an older container object to be checked? E.g.: Brand new method in an old class. Or even: brand new .INCLUDE in an old report. (reported by Rolf Mantel)

Answer: In the past, the tool was behaving like this. Then we received the requirement of inspecting only these new “objects” (instead of the whole wrapping/main object). Personally, we do not see any impediment on enforcing code quality and standards in this new piece of code. Many checks are anyway searching for real errors (e.g.: Empty Catches, Empty IFs, non-class based exceptions, modularization, nesting depth, usage of magical numbers, etc…). But we could evaluate a way of making this a customizable check parameter? E.g.: Check/Resolve Child Objects? I added this to our backlog under the label “feature” and discuss with my colleagues:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.