HttpClient Middleware is not a middleware
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 52
- Forks
- 57
- Avg merge
- 12h 33m
- Merged PRs (30d)
- 18
Description
Please review your concept for http client adapter and documentation for it on:
https://sap.github.io/cloud-sdk/docs/js/features/middleware#benefits-of-middlewares
Let us know how we can improve
Providing custom adapter to make own http requests over node-fetch, undici or other API should be called as "adapter" and not "middleware". Middleware is something you will chain to work on http response. You are providing adapter on this place...
Thanks
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the middleware documentation at https://sap.github.io/cloud-sdk/docs/js/features/middleware#benefits-of-middlewares and review how custom HTTP adapters are described. Check the surrounding documentation for consistent terminology distinguishing adapters from middleware. Done means the concept is accurately named and the affected documentation is updated consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100