SAP / SAP/app-studio-toolkit

Deps mis-alignment: only perform check when the document is actually saved

Open
#185 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
21
Forks
23
Avg merge
1d 15h
Merged PRs (30d)
17

Description

we don't want to trigger checks when the document is un-saved because regardless of the status of the document in memory the quick-fix action works on the real data on disk.

Also this may reduce the number of times we perform the validation by filtering out editing events and may allow us to reduce the debounce wait and provide a more fluid experience to the end user.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the dependency-check trigger and the handling of document edit and save events in the VSCode extension. Confirm that validation runs only after the document is saved, that the quick-fix reads the on-disk data, and that the behavior is covered by the relevant checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.