SAP-samples / SAP-samples/ui5-typescript-helloworld
Incorrect html sample in step-by-step guide
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 79
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
Your sample for test.html in the file step-by-step.md doesn't work as expected if I follow all the steps and open the app on Edge. The button doesn't appear. The reason is that <script> tags should be switched places - the one that contains onInit function should be first, before the other one that has data-sap-ui-on-init property.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open step-by-step.md and locate the test.html sample. Follow the guide and open the app in Edge to reproduce the missing button, then verify the script order around onInit and data-sap-ui-on-init. Done means the sample displays its button when the steps are followed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100