SAP-samples / SAP-samples/ams-samples-java
docs: Javalin sample README claims AMS authorization is an unimplemented TODO, but it is fully implemented
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 0
- Forks
- 0
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 5
Description
ams-javalin-shopping/README.md currently claims authorization isn't implemented [1]. Instead of (as claimed) a stub, the authorization is implemented in AuthHandler.java [2].
[1] https://github.com/SAP-samples/ams-samples-java/blob/main/ams-javalin-shopping/README.md#L114-L123
[2] https://github.com/SAP-samples/ams-samples-java/blob/main/ams-javalin-shopping/src/main/java/com/sap/cloud/security/ams/samples/auth/AuthHandler.java
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read ams-javalin-shopping/README.md at the authorization section and compare its claims with ams-javalin-shopping/src/main/java/com/sap/cloud/security/ams/samples/auth/AuthHandler.java. Update the README so it accurately reflects the implemented authorization, with no remaining claim that it is an unimplemented TODO.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100