SACGF / SACGF/variantgrid

Minor issues

Open
#392 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
30
Forks
3
Avg merge
9h 28m
Merged PRs (30d)
42

Description

** All / General **

* Page titles - “View variant” page title not that descriptive - use “VariantGrid / Shariant: {canonical HGVS}”? - analysis is bad as well
* I think we can now remove from all page: ```{% include "messages/messages.html" %}```

**Analysis**

* Show Analysis name (in toolbar next to build?)
* Analysis Variant Grid - show more info about classifications - date and condition under curation
* Analysis templates snapshot list - should be sorted by date or version?
* Analysis settings - should show read only modified/created date
* Adding a node count - need to trigger full reload of everything if we don't have counts
* Cohort - when VCF or cohort has no genotype should hide most controls
* TagNode - no summary tab?
* GeneListNode - changing to panel app - sets text to name of panel. But if you then reload the analysis, it has changed it to 1x panel app panel
* Rename has_input => takes_input (as may not be connected yet)

**Annotation**

* Annotation page - buttons should have admin key logo
* Descriptions - dbNSFP - all should have the warning about "missense only" or something like: "all potential non-synonymous single-nucleotide variants"
* Annotation page doesn't show GeneInfo loaded or not

** Patients **

* Others can’t modiy patients by default - seqauto should make those writable for everything in seqauto group - maybe why people aren't entering phenotypes into patients?

** Sequencing **

* Seqauto -> Sequencing/software versions - should turn this off or admin only

** Data / Upload **

* Unknown zygosity shouldn’t count for overall stats (obvious on NDCs)
* Code to look for / delete any orphaned variant collection tables (think the clean scritp does this?)
* Upload page - when an uploaded file requires manual intervention (eg bed file that needs build set) should have a (!) yellow or something to indicate needs attention
* VCF upload - should show what genome build it is once it knows (maybe sample count?)
* Separate out ClinVar in sample stats - could just calculate that - would be much quicker than total recalc
* Modified imported variant into own partition - quite a lot...
* Need to work out consistent way to handle uploaded files and produced files - should delete delete it? Ed .ped files don’t delete PedFile but VariantClassification does
* ~CohortGenotypeCollection - make unique_together for cohort/version - data migration to find dupes if exist first?~

**Genes**

* View gene page - doesn't show the GeneInfo icons from GeneGrid - eg BRCA1 pseudogene
* Gene list - nice to be able to edit / modify it - quick way to add a gene
* Gene List - quick way to clone a list
* GeneLists being orphaned when QCGeneList are deleted - need to make signal handlers etc

**Search**

* Search - external PK - should show what types were searched
* ~Search for number doesn’t look in sample~

** Variant details **

* sample variants - Locus should always show, even if no samples

** Cases **

An extra field diagnosis resolved will help determine cases which are AD/AR/x-linked, follow up from segregation etc. this information is different to the LP/P classification. We would ideally have both. A variant classification (already done) and for a given test a diagnosis resolved. Extra field resolved for variant classification level, and on test level - has ancillary Information.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.