Sample Gene List improvements
- Dominant language
- Python
- Stars
- 30
- Forks
- 3
- Avg merge
- 9h 28m
- Merged PRs (30d)
- 42
Description
Moving feature requests / anything we're not doing in VG3 to this issue. From variantgrid_sapath 41:
Passes critical testing. No major bugs, but still really struggling with the the design. Good point to get KK comments?
Minor bug:
- editing a sample GOI in genegrid will cause the gene list columns to swap on saving so that the edited column moves to the right-most position
Things that aren't clear to me:
- still think it's more intuitive to auto-activate upon GOI creation, instead of making all lists inactive. Button/message could be 'create and activate new list'.. or 'new gene list created and activated'.
- is hide supposed to be admin only? Isn't in testing (but working as I'd expect)
- it's possible to hide the active gene list. Wondering if hide should be inaccessible if the gene list is active to make users realise they're inactivating the list as well.
- can still run an analysis when you don't have gene list access, will generate rollbar error but won't prevent analysis creation (not sure if this is good or bad)
- force re-load doesn't update GOI to current active GOI on an open analysis (I think this is good, just checking this is expected behaviour)
At a minimum, the following would be very helpful (but not essential) for function:
- Can we rename hide to something more specific? e.g. 'mark as obsolete' then 'obsolete' rather than hide/hidden (confusing given toggle hides/unhides the gene info & hide doesn't really convey intention)?
- Is it possible to generate a 'page refresh required' message for the bug case mentioned above (I suspect this may be a fairly common occurrence, but not sure - KK?). Also a minor issue if you change active list, the previously active list won't have a 'make active' button until page refreshed
- Could genegrids be removed? Not sure of use case for gene grids on page - really want to see the diff between lists if looking at genes so will probably use genegrid anyway. Also hidden gene lists are lost between grids, gene lists take up lots of real estate & view/edit in genegrid is much more functional. Realistic example here with a fairly small gene list: http://144.6.229.160/snpdb/view_sample/7901
Future dev considerations:
- Is it possible to streamline making a new gene list? Currently download csv, copy list, then paste into create new gene list box. More steps required if using GeneGrid. Think ideal would be to only create/edit in GeneGrid.
- Would be great to show wiki text to encourage documentation of reason for changing GOI.
- I'm assuming GOI permissions are same as gene list permission, not sure what happens when sample-gene list-analysis permissions conflict. Rarely going to be an issue for SAP, can be fixed by admin if arises.
Had a bit of a brainstorm of my ideal if that helps - think it's actually pretty similar, just different design & terminology (+ wiki content!).

Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.