SACGF / SACGF/variantgrid

Classification grid - faded records

Open
#1,691 2 comments 0 reactions 1 assignee Claimed by @davmlaw View on GitHub
Dominant language
Python
Stars
30
Forks
3
Avg merge
9h 28m
Merged PRs (30d)
42

Description

Records are faded if they are not shared

This makes sense in Shariant as it's a way of highlighting that eg a discordance has stopped a record being shared.

But in systems with their own classifications - you end up fading them out by default. I guess this is a way of encouraging people to share (at least in SA Path where they can, not so much research) - this is going to cause a lot of users asking me why

Proposed fixes:
* We only fade when lab is external (this is all classifications on Shariant, and none on SA Path, as we won't see external labs non-shared)
* We use a setting `CLASSIFICATION_GRID_FADE_NON_SHARED` and only set true for Shariant

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.