LabNotificationBuilder - discordance only?
- Dominant language
- Python
- Stars
- 30
- Forks
- 3
- Avg merge
- 9h 28m
- Merged PRs (30d)
- 42
Description
`LabNotificationBuilder` appears to be of general use but uses `from_email=settings.DISCORDANCE_EMAIL,` and seems mostly built for discordances
I think it should either be:
a) renamed `LabDiscordanceNotificationBuilder` and then moved out of utils
b) Remove discordance specific email into config, pass in `settings.DISCORDANCE_EMAIL` from current Shariant uses
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating LabNotificationBuilder in utils and inspecting its current Shariant callers, especially the use of settings.DISCORDANCE_EMAIL. Compare the two proposed directions with the surrounding notification code and configuration. Done means the builder is either clearly discordance-specific and relocated, or reusable with the discordance email supplied by its callers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100