SACGF / SACGF/variantgrid

is_x methods should be properties

Open
#1,467 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
30
Forks
3
Avg merge
9h 28m
Merged PRs (30d)
42

Description

In #1449 I had a very subtle bug where I assumed an is_method was a property, but instead I was doing a truthy test on a method so it always passed.

If you call a is_x property with brackets, you get a not a callable - so you get an error instead of a bug - so that's better

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.