SACGF / SACGF/variantgrid

Distinguish between regular errors and configuration errors

Open
#1,434 1 comment 0 reactions 0 assignees View on GitHub
Biocommons HGVS Refactoring
Dominant language
Python
Stars
30
Forks
3
Avg merge
9h 28m
Merged PRs (30d)
42

Description

I've now hopefully improved a lot of the HGVS search error messages to be more user friendly.
As such, (just in the Shariant branch for now), I no longer convert errors for nonadmin users to "HGVS Search Failed".

I suggest we make a new kind of Error "ConfigurationError", e.g. in mane.py
`"Need to insert genes/transcripts and HGNC"` would be a ConfigurationError. Basically any error message aimed at admins should be a ConfigurationError.

If search gets a ConfiguationError, it should report it to Rollbar and then tell the user that there was a problem, and to try again later.
All other errors should be passed on to the user.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.