SACGF / SACGF/variantgrid

Rename liftover_complete

Open
#1,420 1 comment 0 reactions 1 assignee Claimed by @davmlaw View on GitHub
Dominant language
Python
Stars
30
Forks
3
Avg merge
9h 28m
Merged PRs (30d)
42

Description

From SACGF/variantgrid_private#3761

I misinterpreted what ```liftover_complete``` meant - I thought it meant "liftover succeeded" but it meant "we have stopped trying to liftover"

This has been documented now:

```
:param liftover_complete: Indicates if liftover is complete (and if any missing genome build should be considered an inability to liftover)
builds are newly provided, change etc.
```

But I still think it might be good to rename this for clarity

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.