SACGF / SACGF/variantgrid

Condition Matching / Grouped classification grid

Open
#1,376 2 comments 0 reactions 1 assignee Claimed by @davmlaw View on GitHub
Dominant language
Python
Stars
30
Forks
3
Avg merge
9h 28m
Merged PRs (30d)
42

Description

I suspect these are to do with Shariant/VariantGrid differences, and want to bring up a few things on this topic at once

**1. Condition Matching enabled by default**

Condition matching now seems to be a core feature? If so, I think we should enable the admin condition matching links by default in all environments. I think it is off by default

**2. Non-admin user and condition matching**

Q. Should the non-admin user be able to see a list of condition matching (just theirs - or their lab if they are a head?)

At the moment you can get a 403 with non-admin via

* Login as non-admin user
* Create a classification, add condition
* Click link about condition matching.
* On this condition matching page there is "Back to all Condition Texts", click that and you get a 403 forbidden

**3. Should condition matching be automated, or mandatory?**

If condition matching is super important, could we:

* Auto match exact terms, eg "OMIM:209850" - does this really require human intervention?
* Force the users into condition matching, like we have required fields?

**4. Ontology search should probably have a fallback**

I wasn't familiar with how things work, and entered an exact OMIM term, then went to grid / ontology term page to try and see if the filters worked. The grid was empty, it seems to only work after you have resolved terms. Perhaps we should have a plain text fallback? That would allow us to catch those exact terms (also could solve by making mandatory or auto-match)

Current behavior:

If I pass in ```ontology_term_id='OMIM:209850'``` (autism)

```ClassificationGroupingColumns.condition_filter``` converts it into a list: ```['MONDO:0005258', 'MONDO:0005260', 'OMIM:209850']``` which means that when it is passed into ```classification.models.classification_grouping.ClassificationGroupingSearchTerm.filter_q```

It doesn't do the string search, instead it looks for ClassificationGroupingSearchTerm objects, of which none exist:

```
In [13]: ClassificationGroupingSearchTerm.objects.filter(term_type=ClassificationGroupingSearchTermType.CONDITION_ID).exists()
Out[13]: False
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.