SACGF / SACGF/variantgrid

Upgrade DataTables to version 2

Open
#1,223 1 comment 0 reactions 1 assignee Claimed by @TheMadBug View on GitHub
Dominant language
Python
Stars
30
Forks
3
Avg merge
9h 28m
Merged PRs (30d)
42

Description

We use DataTables for both:

"Client" side HTML (where the server renders out full HTML and then DataTables provides more functionality over the top).
and
Server side where DataTables loads the data as needed off the server, this allows paging, efficient searches etc
We also use a few extensions for DataTables such as fixed headers (so you can see the header when you scroll).

I was looking to update from DataTables 1.x to DataTables 2.x (it provides better client side searching and layout) but there's an extension we use for pagination that has not been updated
```
See datatable_definition.js $.fn.dataTableExt.oPagination.input = {...}
```
this allows us to jump instantly to a page number. If we try to run it with the current extension code we get "plugin is not a function" JavaScript error.

Looking at the docs for DataTables paging can be customised by enabling/disabling the auto jumping of nearby page numbers, enabling/disabling the previous and next buttons and enabling/disabling of the first/last buttons. No option for auto-jumping to a page number is provided.
https://datatables.net/forums/discussion/78354

The ability to jump to a random page is very useful for testing and we'd rather keep it.
This is not a high priority issue, but the sooner we can update to 2, the sooner we can update the layouts from the horrible dom format to something much more readable. It will also keep us future proof etc.
For now not intending on acting on this issue, just wanted to record it.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.