SACGF / SACGF/variantgrid

Sync - check for any Classifications that have historically matched

Open
#1,142 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
30
Forks
3
Avg merge
9h 28m
Merged PRs (30d)
42

Description

If a Classification is changed such that the latest ClassificationModification is no longer caught by the Syncrunner, it won't send an update. An example is changing to Somatic, then to not-somatic for the somatic Shariant upload

I think if a sync destination has ever sent a classification it should be responsible for it for all time. So need to add it to filters

in sync.shariant.variant_grid_upload.VariantGridUploadSyncer.records_to_sync

Instead of:

```qs = qs.filter(q)```

You go:

```
already_sync_q = Q(classification__classificationmodification__classificationmodificationsyncrecord__run__destination=self.sync_destination)
qs = qs.filter(q | already_sync_q)
```

Dave to go back to SA Path and check if this has happened to any existing records and report back here

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.