SACGF / SACGF/variantgrid

Cleanup AlleleSource and old manual migrations

Open
#1,055 0 comments 0 reactions 1 assignee Claimed by @davmlaw View on GitHub
Dominant language
Python
Stars
30
Forks
3
Avg merge
9h 28m
Merged PRs (30d)
42

Description

I have replaced all AlleleSource objects - but won’t delete the models from the database yet - as they are needed to run historical manual migrations etc

We need a "checkpoint" to stop and make sure that people have run all outstanding manual migrations before proceeding with normal migrations

Perhaps this "ensure outstanding completed checkpoint" could be added to "manual"? Pretty easy to find them:

```
from manual.models.manual_migration_models import ManualMigrationOutstanding
ManualMigrationOutstanding.outstanding_tasks
```

Just need to print what commit it is, could commit then go back and change?

—---------------

After that point, we can delete AlleleSource records

—---------

Also need to remove fields:

AlleleSource and FKs to it
AlleleLiftover - variant_allele - haven’t used this yet - will we ever? We can find out the last successful AlleleLiftover for the allele easily enough
Remove “error_message” (been replaced by error)

---------

Also get rid of the "one_off_manual" etc etc

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.