RustCrypto / RustCrypto/traits
Implement `Zeroize` for `NonIdentity<AffinePoint>`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 755
- Forks
- 256
- Avg merge
- 1h 27m
- Merged PRs (30d)
- 2
Description
The way we implement Zeroize for NonIdentity is to set it to the generator point. To that end we rely on the Group trait to get us that generator point. Unfortunately this means Zeroize isn't implemented for NonIdentity<AffinePoint> because they don't implement Group.
This could be solved with specialization on the trait PrimeCurveAffine, but unfortunately Rust isn't there yet.
I propose the following solutions:
- We split
NonIdentityinto two types (see #1170). - Introduce a new trait to get the generator point (similar to https://github.com/zkcrypto/group/issues/41).
(feel free to close the issue if its not considered worth the effort)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by examining the NonIdentity, Zeroize, Group, and PrimeCurveAffine traits and the approaches referenced in #1170 and the linked group issue. Decide which proposed design fits the existing trait structure; done means NonIdentity has a supported Zeroize implementation without relying on unavailable specialization.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cryptography
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100