RustCrypto / RustCrypto/password-hashes
argon2: better SIMD optimizations translated from reference implementation
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 909
- Forks
- 115
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 4
Description
The current argon2 crate implementation is a translation of ref.c from the reference implementation:
https://github.com/P-H-C/phc-winner-argon2/blob/92cd2e1/src/ref.c
It could be improved by translating opt.c instead, which provides e.g. SIMD support:
https://github.com/P-H-C/phc-winner-argon2/blob/92cd2e1/src/opt.c
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the argon2 crate code translated from the linked ref.c, then compare it with the linked opt.c reference implementation. Trace the existing implementation and its validation path before assessing the SIMD translation. Done means the crate reflects the optimized reference behavior while preserving existing Argon2 correctness.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cryptography, security
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100