RustCrypto / RustCrypto/hashes

skein: improve performance

Open
#684 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

performance
Dominant language
Rust
Stars
2.3k
Forks
340
Avg merge
12h 31m
Merged PRs (30d)
2

Description

The C implementation of Skein in https://github.com/pornin/sphlib is 5x+ faster than the one in RustCrypto/hashes.

  skein/512-rust          time:   [1.3714 µs 1.3734 µs 1.3753 µs]
Found 6 outliers among 100 measurements (6.00%)
  4 (4.00%) high mild
  2 (2.00%) high severe
skein/512-sphlib        time:   [200.72 ns 200.79 ns 200.88 ns]
Found 8 outliers among 100 measurements (8.00%)
  3 (3.00%) high mild
  5 (5.00%) high severe

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Skein implementation and its skein/512-rust benchmark, then compare its measurements with the skein/512-sphlib reference shown in the issue. Done means the Rust implementation's benchmark performance is substantially improved and the benchmark results document the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, rust
Domain
cryptography, performance
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.