RustCrypto / RustCrypto/formats

der: drop `Encode`, `Decode`, `Tagged` traits requirements for `IMPLICIT`

Open
#1,746 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
338
Forks
188
Avg merge
4d 6h
Merged PRs (30d)
15

Description

The problem is that Encode and Decode traits are needed for everything encoded with IMPLICIT wrapper.

IMPLICIT wrapper should require only EncodeValue + DecodeValue + IsConstructed.

Related:

  • #1745

I don't know how to split my elephant PR into smaller ones...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull request #1545 and the related issue #1745, since the issue says this work may be part of a larger change. Confirm how the IMPLICIT wrapper currently uses Encode, Decode, Tagged, EncodeValue, DecodeValue, and IsConstructed; done means IMPLICIT requires only the latter three traits and the relevant checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cryptography
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.