RustCrypto / RustCrypto/formats
Inconsistency in leap seconds
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 338
- Forks
- 188
- Avg merge
- 4d 6h
- Merged PRs (30d)
- 15
Description
In https://github.com/RustCrypto/formats/pull/1583 I changed 10 to 37 leap seconds in UNIX timestamp but from_unix and to_unix are still using + 10 and - 10. It should be + 37 and - 37 no ?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the from_unix and to_unix implementations referenced in the issue and compare their offsets with the 37-second value introduced in PR #1583. Update the inconsistent offsets and run the repository's relevant tests to verify both conversions use the same leap-second value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100