RustCrypto / RustCrypto/elliptic-curves

Bug(deps) p521 crate requires ecdsa 16.8

Open
#1,038 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
874
Forks
299
Avg merge
1d 4h
Merged PRs (30d)
12

Description

Hey, doing a minimal versions check on another library, I stumbled on p521 not being able to compile against the stated dependencies.

p521 0.13.3 requires ecdsa 0.16.8 , but specifies 0.16.5

Error Details

error[E0432]: unresolved import `ecdsa_core::hazmat::sign_prehashed`
  --> /Users/joshka/.cargo/registry/src/index.crates.io-6f17d22bba15001f/p521-0.13.3/src/ecdsa.rs:48:30
   |
48 |         hazmat::{bits2field, sign_prehashed, SignPrimitive, VerifyPrimitive},
   |                              ^^^^^^^^^^^^^^ no `sign_prehashed` in `hazmat`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `p521` (lib) due to 1 previous error

Change that introduces the sign_prehashed function
https://github.com/RustCrypto/signatures/commit/d7557a62bc1bb43944d89778fcbb7d4c8b3c9118

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the p521 0.13.3 crate metadata and inspect how its ecdsa dependency is declared. Reproduce the minimal-versions compilation failure, compare it with the linked change introducing sign_prehashed, and verify that the declared dependency resolves to a compatible version.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cryptography
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.