RustCrypto / RustCrypto/crypto-bigint

Proptest Support

Open
#940 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
309
Forks
95
Avg merge
1d 14h
Merged PRs (30d)
3

Description

It would be useful to implement proptest::arbitrary::Arbitrary for various types of this library.

Regular integers and their wrappers could easily be implemented via construction from arrays. But *MontyForm types should implement their own Strategy with a custom ValueTree so they don't always have to reduce after ValueTree::complicate().

This will allow dependents to simply use proptest-derive to add Arbitrary to their own types.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by surveying the library's integer, wrapper, and *MontyForm types, then read proptest::arbitrary::Arbitrary, Strategy, and ValueTree. Determine which types need direct construction strategies and which need custom ValueTree behavior. Done means the relevant types support Arbitrary and dependents can use proptest-derive without unnecessary reductions.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.