[Migrated] spirv-builder should declare dependencies on Cargo.toml files.
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 3.4k
- Forks
- 125
- PR merge metrics
- No merged PRs in 30d
Description
Issue automatically imported from old repo: https://github.com/EmbarkStudios/rust-gpu/issues/404
Old labels: t: enhancement,s: needs update
Originally creatd by eddyb on 2021-02-01T12:18:03Z
For #403 I changed the workspace Cargo.toml, but that didn't result in a rebuild of sky-shader, whereas something like this does cause a rebuild (of example-runner-wgpu, in this example):
[profile.dev.package."example-runner-wgpu"]
opt-level = 3
So I think we need spirv-builder to get the workspace Cargo.toml (and Cargo.lock, I suppose) paths from Cargo somehow, and also list those out as "rebuild if changed".
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing spirv-builder and how it obtains Cargo metadata for sky-shader, then compare the workspace Cargo.toml and Cargo.lock behavior with the example-runner-wgpu case described in the issue. Confirm how Cargo marks files for rebuild and add or update focused coverage so workspace manifest changes trigger the expected rebuild.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100