Rust-GCC / Rust-GCC/gccrs

Remove `GenericArg::Kind::Error` and turn all instances of `GenericKind` into `tl::optional<GenericKind>` instead

Open
#3,719 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cleanup good-first-pr
Dominant language
C++
Stars
2.9k
Forks
231
Avg merge
20h 2m
Merged PRs (30d)
66

Description

The class is used in classes like ConstGenericParam and is confusing to use when we now have proper optional values

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating GenericArg::Kind::Error, GenericKind, and their uses in classes such as ConstGenericParam. Trace how absent values are represented before replacing each GenericKind instance with tl::optional; done means the error kind and all direct GenericKind instances are removed without breaking compiler behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.