Rust-GCC / Rust-GCC/gccrs

Make sure there aren't other `ExpandVisitor` parent-replacement bugs

Open
#3,448 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
2.9k
Forks
231
Avg merge
19h 55m
Merged PRs (30d)
67

Description

There may be bugs similar to #3444, where ExpandVisitor expands an AST node and replaces a parent of that node with the expansion, rather than the node itself.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #3444 and then inspect the ExpandVisitor implementation for cases where an expanded AST node is substituted into its parent. Identify any other parent-replacement cases with the same behavior and verify each one against the intended node replacement semantics; the issue is done when similar bugs are either fixed or ruled out.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, rust
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.