Rust-GCC / Rust-GCC/gccrs

Refactor this to use the implicit insert

Open
#3,395 2 comments 0 reactions 1 assignee View on GitHub

@mostafa630 is already working on this.

Since Mar 5, 2025.

  • #3467 by @mostafa630 — closed without merging
cleanup good-first-pr
Dominant language
C++
Stars
2.9k
Forks
231
Avg merge
19h 55m
Merged PRs (30d)
67

Description

We are calling insert type using the node mappings helper but this should be calling insert_implicit_type so we just pass the hirid through which is much cleaner

https://github.com/Rust-GCC/gccrs/blob/3c21102b7378b9a4d61c36689063f6104e751ff6/gcc/rust/typecheck/rust-substitution-mapper.cc#L156

https://github.com/Rust-GCC/gccrs/blob/3c21102b7378b9a4d61c36689063f6104e751ff6/gcc/rust/typecheck/rust-substitution-mapper.cc#L163

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.