Rust-GCC / Rust-GCC/gccrs

Refactor helper functions around attributes

Open
#3,291 2 comments 0 reactions 1 assignee View on GitHub

@saeitoshi-10 is already working on this.

Since Dec 21, 2024.

cleanup good-first-pr
Dominant language
C++
Stars
2.9k
Forks
231
Avg merge
19h 55m
Merged PRs (30d)
67

Description

We should introduce some helper function here instead, I'm sure it would be reused elsewhere and it would ease this function a bit.
Probably within rust-attributes.cc since we already have some similar functions there ?

Originally posted by @P-E-P in https://github.com/Rust-GCC/gccrs/pull/3289#discussion_r1869691014

There are plenty of places where attributes are being checked or used and a lot of repetition is happening. We have just added an Attributes class to rust-attributes.cc, and it would be nice to collect functions related to attributes in that class.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.