asm parser lacking `label` parse functionality
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.9k
- Forks
- 231
- Avg merge
- 20h 2m
- Merged PRs (30d)
- 66
Description
In rust's asm.rs I misunderstood eat_keyword(label) for "tracks if there is any number that is followed by a :" to be a label. The former is explicitly a label and the latter is a local label.
The former needs to be parsed explicitly and put in a hashmap or set to be expanded later.
The latter can be implicitly parsed via parse_format_strings, it is passed straight into the assembler.
For docs
rust zulip asm discussion
arm's docs on local label
rust's asm goto
rust's tracking issue
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Rust's asm.rs, then read the linked Zulip discussion, ARM local-label documentation, and Rust asm-goto tracking issue. Confirm the distinction between explicit labels and local labels: explicit labels should be retained for later expansion, while local labels continue through parse_format_strings. Done means both forms are parsed according to that distinction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100