Rust-GCC / Rust-GCC/gccrs

Cleanup `AST::MacroInvocation` class

Open
#2,919 2 comments 0 reactions 1 assignee View on GitHub

@v1bh475u is already working on this.

Since Feb 5, 2026.

cleanup good-first-pr
Dominant language
C++
Stars
2.9k
Forks
231
Avg merge
20h 2m
Merged PRs (30d)
66

Description

The current implementation inherits from a lot of base classes, which is necessary, but does not always constructs all of them. Both of its constructors do not call into the same base class constructors for example. Similarly, this class has a lot of duplicate members with its base classes (locus, node_id) which we need to sort out

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.