Rust-GCC / Rust-GCC/gccrs

Change `ErrorCode` location after the `error:`

Open
#2,522 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
2.9k
Forks
231
Avg merge
19h 55m
Merged PRs (30d)
67

Description

The error code is after the diagnostic message, whereas rustc puts it after the word "error". I could change that in gcc's diagnostic.cc, perhaps.

Originally posted by @davidmalcolm in https://github.com/Rust-GCC/gccrs/pull/1408#issue-1313911460

Currently, the error codes are emitted after the error message in gccrs, we tried to move that after the error:. But we have a fear that it might break other languages frontend.

Funfact: Older versions of rustc also emits error message after the error message. The error code after the error: is added in rustc 1.12.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in gcc's diagnostic.cc and compare current gccrs diagnostics with rustc's placement of the error code. Check how the change affects other language frontends, then verify that gccrs emits the code after error: without regressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, rust
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.