Unify `MacroLexer` and `ProcMacroInvocLexer` under one class
Open
Nobody has claimed this yet.
cleanup
- Dominant language
- C++
- Stars
- 2.9k
- Forks
- 231
- Avg merge
- 19h 55m
- Merged PRs (30d)
- 67
Description
I'm wondering if we could have a `MacroInvocLexer<T>` that accepts both kinds of tokens :thinking: but that's a story for another PR
Originally posted by @CohenArthur in https://github.com/Rust-GCC/gccrs/pull/2218#discussion_r1221486906
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names MacroLexer and ProcMacroInvocLexer but mentions no files, tests, or entry points. Start by locating both class definitions and their usages, then compare their token-handling responsibilities; done means they are unified without changing existing lexer behavior and the relevant tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100