`SimplePath` & `PathInExpression` AST node structure
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.9k
- Forks
- 230
- Avg merge
- 19h 55m
- Merged PRs (30d)
- 67
Description
According to the reference, SimplePath has always at least one SimplePathSegment.
::? SimplePathSegment (:: SimplePathSegment)*
Currently SimplePathSegment has the following attributes:
boolhas_opening_scope_resolutionstd::vector<SimplePathSegment>segments- [...]
This means the vector is never empty and is_empty always return false.
We should either:
- Have an additional member like in
QualifiedPathInExpression - "Fix
is_empty"
Depending on the chosen approach we might also need to refactor PathInExpression.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the SimplePathSegment and PathInExpression AST definitions and compare their structure with the Rust Reference's simple-path grammar. Review QualifiedPathInExpression as the issue's example, then trace usages of is_empty and the affected nodes. Done means the representation matches the grammar and any required PathInExpression refactoring is complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, rust
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100