Rust-GCC / Rust-GCC/gccrs

Handle types in closures properly during privacy pass

Open
#1,264 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
2.9k
Forks
231
Avg merge
20h 2m
Merged PRs (30d)
66

Description

I think CLOSURE might be the only one that needs special handling here as closures can contain explicit types:

mod foo {
    struct Priv;
}

fn outer() {
    let closure = |value: foo::Priv| -> foo::Priv { value };
}

I'll make them all return except for closures, does that sound good?

Originally posted by @CohenArthur in https://github.com/Rust-GCC/gccrs/pull/1258#discussion_r878043921

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the privacy pass and its CLOSURE handling, then trace how explicit closure parameter and return types are processed. Confirm the behavior with a compiler test covering the example; done means closure types are handled correctly without regressing other privacy-pass cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, rust
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.