Rust-GCC / Rust-GCC/gccrs

Handle optional `:vis` specifier properly

Open
#1,104 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
2.9k
Forks
231
Avg merge
19h 55m
Merged PRs (30d)
67

Description

It seems that the :vis fragment specifier might be optional in some cases. We should look into how rustc handles it and make sure that we add addequate testing to handle the behavior.

https://veykril.github.io/tlborm/decl-macros/minutiae/fragment-specifiers.html#vis

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked TLBORM section and compare the optional :vis behavior with rustc. Then locate gccrs's fragment-specifier handling and its existing tests, and add coverage for the supported cases so the behavior matches rustc.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, rust
Domain
compilers, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.