Rust-GCC / Rust-GCC/gccrs

Refactor array_initializer into rust-tree.[ch]

Open
#1,095 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cleanup enhancement good-first-pr
Dominant language
C++
Stars
2.9k
Forks
231
Avg merge
19h 55m
Merged PRs (30d)
67

Description

https://github.com/Rust-GCC/gccrs/blob/e43a5c5373b341d217d2f5403f31f5174b8c4e2f/gcc/rust/rust-gcc.cc#L1699-L1702

Can we make an issue to pull this out into rust-tree.h at some point it would be nice to eventually get rid of this abstraction since you have done most of the hard work for it :D

Originally posted by @philberty in https://github.com/Rust-GCC/gccrs/pull/1087#discussion_r845864737

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at gcc/rust/rust-gcc.cc lines 1699-1702 and inspect the related rust-tree.h and rust-tree.c files. Determine how array_initializer should be moved into rust-tree.h and how the existing abstraction is intended to be removed; completion should leave the refactor integrated without breaking the compiler.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.