RosettaCommons / RosettaCommons/RFdiffusion

Error in latest commit

Open
#273 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3.1k
Forks
644
PR merge metrics
No merged PRs in 30d

Description

I think in the following line, conf instead of conf.scaffoldguided should be used.

https://github.com/RosettaCommons/RFdiffusion/blob/b44206a2a79f219bb1a649ea50603a284c225050/rfdiffusion/inference/model_runners.py#L751

When conf.scaffoldguided is used, it will trigger error at

https://github.com/RosettaCommons/RFdiffusion/blob/b44206a2a79f219bb1a649ea50603a284c225050/rfdiffusion/inference/utils.py#L694

because self.conf.scaffoldguided is a Boolean and does not have the scaffold_list property

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect rfdiffusion/inference/model_runners.py at line 751 and rfdiffusion/inference/utils.py at line 694. Trace the scaffold-guided inference path and confirm how the Boolean configuration reaches scaffold_list. Done means the reported error no longer occurs for this path.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.