RosettaCommons / RosettaCommons/RFdiffusion

About ‘Generation of Symmetric Oligomers’

Open
#20 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3.1k
Forks
644
PR merge metrics
No merged PRs in 30d

Description

Hi,in the part of ‘Generation of Symmetric Oligomers’,
I saw the command is:
"./scripts/run_inference.py --config-name symmetry inference.symmetry=tetrahedral 'contigmap.contigs=[360]' inference.output_prefix=test_sample/tetrahedral inference.num_designs=1"
, but an error will be reported when running:
File ".../RFdiffusion/rfdiffusion/contigs.py", line 137, in get_sampled_mask
contig_list = self.contigs[0].strip().split()
AttributeError: 'int' object has no attribute 'strip'

the symmetry.yaml in config/inference is set as follow:
contigmap:
# Specify a single integer value to sample unconditionally.
# Must be evenly divisible by the number of chains in the symmetry.
contigs: ['100']

So, is there some problem in this part?

Finally, please standardize the content of the README.md, because there seem to be some differences between the README.md and the code,thanks

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the documented command and inspect rfdiffusion/contigs.py around get_sampled_mask, then compare its expected contigs type with config/inference/symmetry.yaml. Review README.md against the current configuration and command behavior. Done means the documented oligomer-generation example runs without the reported AttributeError and the README matches the relevant code and configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation, machine-learning
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.