Roll20 / Roll20/roll20-api-scripts

Adding arg for type of Critical

Open
#898 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
407
Forks
602
Avg merge
7d 55m
Merged PRs (30d)
18

Description

Hello, thanks for this script.

Is it possible to add args after !critical to choose which type of critical ? (Like !critical pierce if I want the pierce one).

Thank you :)

Brandys

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the script that implements the !critical command and inspect how its command arguments are parsed. Confirm which critical types are supported and define completion as allowing a type such as "pierce" after !critical while preserving the existing command behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
game-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.