Roll20 / Roll20/roll20-api-scripts

Script crashes API server when used

Open
#2,157 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
407
Forks
602
Avg merge
7d 55m
Merged PRs (30d)
18

Description

When triggered with any chosen check, the script crashes the API server with the following error:

For reference, the error message generated was: TypeError: attrValue.match is not a function TypeError: attrValue.match is not a function at apiscript.js:14586:29 at String.replace (<anonymous>) at processFormula (apiscript.js:14580:27) at processTokenRollData (apiscript.js:14612:46) at apiscript.js:14867:24 at Array.map (<anonymous>) at handleRolls (apiscript.js:14866:45) at handleInput (apiscript.js:14906:63) at file:///home/node/d20-api-server/src/pubsub2.js:42:46 at Map.forEach (<anonymous>)

Hadn't changed anything since I had successfully been using it for several years. Set to use Latest version from the API library. Tried in both the normal and experimental API server. Using it for a purchased 5e module with D&D 5e 2014 character sheets and under Jumpgate.

Thread of similar problems here: https://app.roll20.net/forum/post/12198934/group-check-slash-apply-damage-not-working

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the stack trace in apiscript.js around lines 14580-14586, then follow processTokenRollData and handleRolls through the API server entry point in src/pubsub2.js. Reproduce the failure with a chosen check in the normal and experimental API servers, and compare it with the similar-problems thread; done means the script no longer crashes the API server.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.