Roll20 / Roll20/roll20-api-scripts

the formulas of the skills don't get the proficiency bonus properly

Open
#2,061 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
407
Forks
602
Avg merge
7d 55m
Merged PRs (30d)
18

Description

https://github.com/Roll20/roll20-api-scripts/blob/b8504107b3d460fdf2a63cd00bc95fea1b29d3c7/GroupCheck/GroupCheck.js#L594

the formula should be something like [[d20 + ([[d0 + @{acrobatics_bonus}@{pbd_safe}]]*(1-ceil((@{npc})*0.1)) [PC] + (@{npc_acrobatics}*@{npc}) [NPC]]] for every skill.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read GroupCheck/GroupCheck.js around line 594 and compare the existing skill formula with the expression supplied in the issue. Trace how the proficiency bonus is handled for PC and NPC skills, then verify that the corrected formula is applied consistently to every skill.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.