Roll20 / Roll20/roll20-api-scripts

API categorized as "hidden" still show up in API Script One-Click

Open
#1,136 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
407
Forks
602
Avg merge
7d 55m
Merged PRs (30d)
18

Description

Some time ago, I submitted #1106, which was supposed to remove two redundant API from being listed in the API Script One-Click menu, but it seems adding the "hidden" parameter to scripts in the approved.yaml doesn't actually hide them in the menu, like it does with Character Sheets in the Character sheet Repo's approved.yaml.

I noticed that two other APIs (5e Shaped Companion Script, True Page Copy) also have the hidden parameter, but are likewise still visible in the API menu.

Could it be fixed so that the "hidden"-parameter works for API scripts like how it does for character sheets, or does scripts need to be removed form the repo/from approved.yaml to no longer be visible?

@samus was the last one to merge changes in the repo, maybe you can take it up with the other Devs?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with approved.yaml and inspect the hidden entries for 5e Shaped Companion Script and True Page Copy, then trace how the API Script One-Click menu reads that configuration. Compare the behavior with the linked character-sheet approved.yaml; done means hidden API scripts no longer appear in the API menu while visible scripts still do.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, yaml
Domain
api, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.