RocketChat / RocketChat/homeserver

pruneEventDict and signEvent's `prune` flag should go away entirely, replaced by

Open
#411 0 comments 0 reactions 1 assignee View on GitHub

@sampaiodiego is already working on this.

Since Aug 31, 2026.

todo :spiral_notepad: type: feature
Dominant language
TypeScript
Stars
16
Forks
18
PR merge metrics
No merged PRs in 30d

Description

PersistentEventFactory.createFromRawEvent(event, roomVersion).redactedEvent. Blocked on migrating the 28 remaining signEvent(..., prune=true) call sites in packages/core/src/events/*.spec.ts. m.room.create.spec.ts already signs the same fixture both ways and gets an identical signature, so the migration should preserve every hardcoded signature fixture rather than require regenerating them — a failure there would be a real divergence between the two redaction implementations.


https://github.com/RocketChat/homeserver/blob/3539adcd7ea7b98481889bcd1ebb73223bf64c21/packages/core/src/utils/pruneEventDict.spec.ts#L41-L43


This issue was generated by todo-issue based on a TODO comment in 3539adcd7ea7b98481889bcd1ebb73223bf64c21. It's been assigned to @sampaiodiego because they committed the code.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.