RocketChat / RocketChat/fuselage
Suggestion: avoid autolink for bare localhost
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 162
- Forks
- 258
- Avg merge
- 2d 23h
- Merged PRs (30d)
- 24
Description
I found https://github.com/RocketChat/fuselage/pull/962 and https://github.com/rocketchat/rocket.chat/issues/28427, where it looks like the link parser is configured to auto-link valid FQDN hostnames and also turn explicit URLs (including a scheme) into links more consistently even when the hostname is local.
My suggestion is that, if possible, localhost specifically should be excluded from this behavior. At the moment, just including the bare word "localhost" in a chat message creates a link https://localhost. To a first approximation, this is basically never what the author intended.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the link-parser behavior discussed in RocketChat/fuselage#962 and rocket.chat#28427, then locate the parser entry point in this repository. Done means a bare “localhost” is not converted into https://localhost while explicit URLs, including local ones with a scheme, continue to link consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100