RocketChat / RocketChat/Rocket.Chat
[BUG] When set to display aliases instead of usernames, reactions are displayed as coming from usernames
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
On our server, Set a User Name to Alias in Message is set to True. This setting does not affect emoji reacts, and it seems like it should.
Server Setup Information:
- Version of Rocket.Chat Server: 0.61.0
- Operating System: All
- Deployment Method(snap/docker/tar/etc): Docker
- Number of Running Instances: 1
- DB Replicaset Oplog: Enabled
- Node Version: v8.9.3
Steps to Reproduce:
- Set
Set a User Name to Alias in Messageto True - Post a message
- Have someone else react to that message
Expected behavior:
I expect to see that Pejman posted a react and not @thepageman.
Actual behavior:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Reproduce the problem with “Set a User Name to Alias in Message” enabled, then trace the reaction display path and its use of user names; done means reaction authors display their aliases instead of usernames, with coverage for the setting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100