RocketChat / RocketChat/Rocket.Chat

SSL error when posting a link to a website with broken HTTPS link in meta og:image

Open
#9,653 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

I just posted a link to https://www.smore.com/clippy-js into a Rockat.Chat channel. This caused a "Do you trust certificate from "DigiCert Baltimore CA-2 G2"?" error popup:

error

The cause of this error is this meta tag on the website:

    <meta property="og:image" content="https://clippy.js.s3.amazonaws.com/og.jpg"/>

The SSL certificate covers only *.s3.amazonaws.com, so clippy.js.s3.amazonaws.com is not covered.

Rocket.Chat should IMO only log errors like these in the console, and not load the preview image.

Server Setup Information:
  • Version of Rocket.Chat Server: 0.60.3
  • Operating System: Debian stretch
  • Deployment Method(snap/docker/tar/etc): tar
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Disabled
  • Node Version: v8.9.3
Steps to Reproduce:
  1. Post a link to https://www.smore.com/clippy-js in a Rocket.Chat channel
Expected behavior:

No image should be loaded, no popup error message should be displayed.

Actual behavior:

An error message is displayed in a popup.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the link-preview request for https://www.smore.com/clippy-js and inspect handling of its og:image URL, https://clippy.js.s3.amazonaws.com/og.jpg. Confirm that the invalid certificate is handled without a popup and that the preview image is not loaded; the payload names no source file or test to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.